Core: Remove deprecated validation APIs in MergingSnapshotProducer#7150
Merged
jackye1995 merged 1 commit intoapache:masterfrom Mar 21, 2023
Merged
Conversation
amogh-jahagirdar
force-pushed
the
branch-remove-old-validation-apis
branch
from
03bd312 to
df39ad5
Compare
amogh-jahagirdar
changed the title
Contributor
|
@amogh-jahagirdar just FYI that you'd need #7155, otherwise the added RevAPI breaks are under the wrong version |
nastra
reviewed
Mar 21, 2023
amogh-jahagirdar
force-pushed
the
branch-remove-old-validation-apis
branch
from
df39ad5 to
85033c1
Compare
Contributor
Author
|
Good catch @nastra , I just rebased, and now it's under the right version. |
amogh-jahagirdar
force-pushed
the
branch-remove-old-validation-apis
branch
from
85033c1 to
0195e7b
Compare
amogh-jahagirdar
force-pushed
the
branch-remove-old-validation-apis
branch
from
0195e7b to
14300a0
Compare
nastra
approved these changes
Mar 21, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
this LGTM, thanks @amogh-jahagirdar. I'll wait for this PR to be merged and rebase #7156 then
singhpk234
approved these changes
Mar 21, 2023
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM as well, Thanks @amogh-jahagirdar !
Contributor
|
Thanks for the work @amogh-jahagirdar ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of branch write work, we deprecated the
validationAPIs inMergingSnapshotProducerin favor of newvalidationAPIs which require explicit passing of the branch. This change removes those deprecated APIs for 1.3.0 and updates rev API.cc: @rdblue @namrathamyske @jackye1995