Skip to content

Flink: Introduce Flink 1.17#7254

Merged
stevenzwu merged 4 commits intoapache:masterfrom
hililiwei:f1.17
Apr 8, 2023
Merged

Flink: Introduce Flink 1.17#7254
stevenzwu merged 4 commits intoapache:masterfrom
hililiwei:f1.17

Conversation

@hililiwei
Copy link
Copy Markdown
Contributor

@hililiwei hililiwei commented Mar 31, 2023 •
edited by Fokko
Loading

There are 4 commits, please do not use Squash.

Resolves: #7250

@hililiwei
Copy link
Copy Markdown
Contributor Author

hililiwei commented Mar 31, 2023

I'm not sure why approval is needed to execute UT. @stevenzwu Could you please help to review it?

@stevenzwu stevenzwu self-requested a review March 31, 2023 15:40
stevenzwu
stevenzwu reviewed Mar 31, 2023
View reviewed changes
Comment thread flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java Outdated
Comment thread flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java
Comment thread flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java
Comment thread flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java
stevenzwu
stevenzwu reviewed Apr 4, 2023
View reviewed changes
Comment thread flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java
Comment thread flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java Outdated
Comment thread flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java
Comment thread flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java
911432
911432 reviewed Apr 7, 2023
View reviewed changes
Comment thread .github/workflows/flink-ci.yml
@@ -62,7 +62,7 @@ jobs:
strategy:
matrix:
jvm: [8, 11]
Copy link
Copy Markdown
Contributor

@911432 911432 Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if Java 8 needs to be uninstalled.
This is because, according to the Flink 1.17 documentation, Flink 1.17 requires Java 11, not Java 8.
https://nightlies.apache.org/flink/flink-docs-release-1.17/docs/try-flink/local_installation/

However, looking at the Dockerfile it seems Java 8 is still supported.
https://github.com/apache/flink-docker/tree/master/1.17

Copy link
Copy Markdown
Contributor Author

@hililiwei hililiwei Apr 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Java 8 and 11 are supported (though 8 has been deprecated).

@hililiwei
Copy link
Copy Markdown
Contributor Author

hililiwei commented Apr 7, 2023

Rebase this pr because #7269 was merged.

stevenzwu
stevenzwu approved these changes Apr 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@stevenzwu stevenzwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for one nit on adding comment, this PR looks good.

Comment thread flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java
@stevenzwu stevenzwu merged commit 9223251 into apache:master Apr 8, 2023
@stevenzwu
Copy link
Copy Markdown
Contributor

stevenzwu commented Apr 8, 2023

thanks @hililiwei for the contribution

This was referenced Apr 10, 2023
Closed
Closed
@zhongyujiang zhongyujiang mentioned this pull request Apr 11, 2023
Closed
@pvary pvary mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenzwu stevenzwu stevenzwu approved these changes

+1 more reviewer

@911432 911432 911432 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build flink INFRA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When will Flink1.17 be supported?

3 participants

@hililiwei @stevenzwu @911432