Skip to content

Flink: backport PR #7494. change sink shuffle to use RowData as data type and statistics key type #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevenzwu merged 1 commit into from
May 18, 2023
Merged

Flink: backport PR #7494. change sink shuffle to use RowData as data type and statistics key type #7632

stevenzwu merged 1 commit into from
May 18, 2023

Conversation

@stevenzwu
Copy link
Contributor

@stevenzwu stevenzwu commented May 17, 2023

confirmed the following diff as expected

➜  iceberg git:(backport-7494) ✗ git diff --no-index  flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle  flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/shuffle
➜  iceberg git:(backport-7494) ✗ git diff --no-index  flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle  flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle

➜  iceberg git:(backport-7494) ✗ git diff --no-index  flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle  flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle
➜  iceberg git:(backport-7494) ✗ git diff --no-index  flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle  flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle

@stevenzwu stevenzwu requested a review from pvary May 17, 2023 14:29
@github-actions github-actions bot added the flink label May 17, 2023
@stevenzwu stevenzwu merged commit 67decf9 into apache:master May 18, 2023
@stevenzwu
Copy link
Contributor Author

stevenzwu commented May 18, 2023

thanks @pvary for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvary pvary pvary approved these changes

Assignees

No one assigned

Labels

flink

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenzwu @pvary