Python: Refactor integration tests #7698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
force-pushed
the
fd-refactor-integration-tests
branch
from
a5fb6ba to
85d384c
Compare
This splits out running and building the integration tests that enables quick development iterations. I've also added ipython that will give a more meaningful error when something goes wrong with the provisioning of the tests.
Fokko
force-pushed
the
fd-refactor-integration-tests
branch
from
85d384c to
b2c866b
Compare
python/dev/provision.py
Outdated
| CREATE TABLE test_null_nan_rewritten | ||
| USING iceberg | ||
| AS SELECT * FROM test_null_nan | ||
| CREATE OR REPLACE TABLE default.test_limit |
Contributor
There was a problem hiding this comment.
This might be simplified to:
CREATE OR REPLACE TABLE default.test_limit as
SELECT * LATERAL VIEW explode(ARRAY(1, 2, 3, 4, 5, 6,7, 8, 9, 10)) AS idx;
danielcweeks
approved these changes
May 25, 2023
Fokko
force-pushed
the
fd-refactor-integration-tests
branch
from
c5bf263 to
db307b3
Compare
Contributor
Author
|
Thanks @danielcweeks for the review! 👍🏻 |
Fokko
added a commit
to Fokko/iceberg
that referenced
this pull request
May 28, 2023
This reverts commit 3a584a2.
nastra
pushed a commit
that referenced
this pull request
May 30, 2023
Fokko
added a commit
to Fokko/iceberg
that referenced
this pull request
Jun 4, 2023
* Python: Refactor integration tests This splits out running and building the integration tests that enables quick development iterations. I've also added ipython that will give a more meaningful error when something goes wrong with the provisioning of the tests. * Simplify SQL
Fokko
added a commit
that referenced
this pull request
Jun 5, 2023
* Python: Refactor integration tests (#7698) * Python: Refactor integration tests This splits out running and building the integration tests that enables quick development iterations. I've also added ipython that will give a more meaningful error when something goes wrong with the provisioning of the tests. * Simplify SQL * Bump to Iceberg 1.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out running and building the integration tests that enables quick development iterations. I've also added ipython that will give a more meaningful error when something goes wrong with the provisioning of the tests.