Core: Deprecate newOutputFile from {ClusteredWriter,FanoutWriter}
#7788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not used anymore
Fokko
changed the title
newOutputFile from `{ClusteredWriter,FanoutWriter}newOutputFile from {ClusteredWriter,FanoutWriter}
Contributor
Author
aokolnychyi
reviewed
Jun 7, 2023
aokolnychyi
approved these changes
Jun 7, 2023
Contributor
There was a problem hiding this comment.
Thanks, @Fokko! LGTM. One question about the deprecation notice. Merge whenever you are ready.
Fokko
commented
Jun 7, 2023
rodmeneses
pushed a commit
to rodmeneses/iceberg
that referenced
this pull request
Feb 19, 2024
…apache#7788) * Core: Deprecate `newOutputFile` from `{ClusteredWriter,FanoutWriter} They are not used anymore * Update core/src/main/java/org/apache/iceberg/io/ClusteredWriter.java * Update core/src/main/java/org/apache/iceberg/io/FanoutWriter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not used anymore