Skip to content

fix InclusiveMetricsEvaluator to handle negative row counts #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 1 commit into from
Feb 18, 2020
Merged

fix InclusiveMetricsEvaluator to handle negative row counts #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,17 @@ private class MetricsEvalVisitor extends BoundExpressionVisitor<Boolean> {
private Map<Integer, ByteBuffer> upperBounds = null;

private boolean eval(DataFile file) {
if (file.recordCount() <= 0) {
if (file.recordCount() == 0) {
return ROWS_CANNOT_MATCH;
}

if (file.recordCount() < 0) {
// we haven't implemented parsing record count from avro file and thus set record count -1
// when importing avro tables to iceberg tables. This should be updated once we implemented
// and set correct record count.
return ROWS_MIGHT_MATCH;
}

this.valueCounts = file.valueCounts();
this.nullCounts = file.nullValueCounts();
this.lowerBounds = file.lowerBounds();
Expand Down