Api: Update deprecated calls to Transforms APIs #8206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Fokko, I was working on partitioning when I came across these deprecated calls in PartitionSpec. I have created this pull request with the updated calls. Please take a look. I saw your pull request (#6220) that reverted to these deprecated calls to resolve compatibility issues in Trino. The calls have been updated on the Trino side (trinodb/trino#15544) as well as on the Presto side (prestodb/presto#20416). Please let me know if you have a different course of action in mind. Thanks in advance! |
Fokko
approved these changes
Aug 2, 2023
Contributor
|
@s-akhtar-baig thanks for updating this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: PartitionSpec uses deprecated calls to Transforms methods. These changes were made to resolve compatibility issues in Trino. Trino and Presto now use latest iceberg Transforms APIs and these calls can be updated as well if there no other concerns.