GCP: Add bundle jar for GCP-related dependencies#8231
Merged
nastra merged 10 commits intoapache:masterfrom Aug 8, 2023
Merged
Conversation
danielcweeks
reviewed
Aug 7, 2023
gcp-bundle/NOTICE
Outdated
|
|
||
| -------------------------------------------------------------------------------- | ||
|
|
||
| This binary artifact includes Project Nessie with the following in its NOTICE |
Contributor
There was a problem hiding this comment.
@bryanck I think we need to revisit the LICENSE and NOTICE files. If this is just a GCP bundle, it shouldn't include all of the Iceberg and related dependencies. Just the GCP notice.
Contributor
Author
There was a problem hiding this comment.
Yes, thanks. I updated these.
danielcweeks
approved these changes
Aug 7, 2023
nastra
approved these changes
Aug 8, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM, just left some minor comments on the license file
gcp-bundle/LICENSE
Outdated
|
|
||
| Group: com.google.code.gson Name: gson Version: 2.10.1 | ||
| Project URL: https://github.com/google/gson/gson | ||
| License: "Apache-2.0";link="https://www.apache.org/licenses/LICENSE-2.0.txt" (Not packaged) |
Contributor
There was a problem hiding this comment.
should we remove this line maybe?
gcp-bundle/LICENSE
Outdated
| -------------------------------------------------------------------------------- | ||
|
|
||
| Group: org.checkerframework Name: checker-qual Version: 3.33.0 | ||
| License: MIT (Not packaged) |
Contributor
Author
There was a problem hiding this comment.
Thanks, I removed these lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR packages the Iceberg GCP library in a similar way to the Iceberg AWS library. The
icberg-gcpproject is packaged with the engine runtimes (Spark, Flink, Hive) without the GCP dependencies, similar to howiceberg-awsis included without the AWS dependencies. This has a negligible impact on the engine runtime size.In the
iceberg-gcpproject, the GCP dependencies are changed to compile-only. This mirrors how the AWS dependencies are declared iniceberg-aws. While this could impact those usingiceberg-gcptoday, the thought is that there may not be many heavy users of it, as there was a critical bug in the GCP reader that was only recently fixed and is not in a release yet (#8071). Current users would need to add the GCP dependencies to their build.Finally, a new
iceberg-gcp-bundleproject is added that packages the necessary GCP libraries and shades any packages that might conflict with engine libraries. This allows users to simply include two dependencies when using Iceberg on GCP, e.g. for Spark,iceberg-spark-runtimeandiceberg-gcp-bundle. (AWS users similarly can specify the AWS bundle, but Google doesn't provide something similar.)