Core, Hive, Nessie: Use ResolvingFileIO as default instead of HadoopFileIO#8272
Core, Hive, Nessie: Use ResolvingFileIO as default instead of HadoopFileIO#8272nastra wants to merge 1 commit intoapache:mainfrom
Conversation
nastra
force-pushed
the
resolving-file-io-as-default
branch
from
948a917 to
fb23e4d
Compare
nastra
force-pushed
the
resolving-file-io-as-default
branch
from
fb23e4d to
fcbc64e
Compare
|
Also, can we make it support SupportsPrefixOperations. Thinking it a possible option for: #8194 |
@szehon-ho did you mean to comment on #7976 w.r.t |
dramaticlly
left a comment
dramaticlly
left a comment
There was a problem hiding this comment.
change LGTM, do we need to update docs anywhere to better inform user? Since this default value change and some might not be fully aware of
This change should be completely transparent for users |
nastra
force-pushed
the
resolving-file-io-as-default
branch
from
fcbc64e to
d24c581
Compare
| private static final String NAMESPACE_EXISTS_PROPERTY = "exists"; | ||
| private static final Logger LOG = LoggerFactory.getLogger(JdbcCatalog.class); | ||
| private static final Joiner SLASH = Joiner.on("/"); | ||
| private static final String DEFAULT_FILE_IO_IMPL = "org.apache.iceberg.io.ResolvingFileIO"; |
There was a problem hiding this comment.
You could use the name from the class potentially, rather than a string literal, as ResolvingFileIO is in core.
|
I think we need to discuss this more before merging it. This will change the default |
|
I remember discussing this in the community sync. Why this didn't move forward? |
|
@ajantha-bhat this will be done prior to releasing 2.0.0 |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
7 participants
No description provided.