Skip to content

Core, Spark 3.4: Write properties of PositionDeletesTable should respect ones of BaseTable #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szehon-ho merged 6 commits into from
Sep 19, 2023
Merged

Core, Spark 3.4: Write properties of PositionDeletesTable should respect ones of BaseTable #8428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46b1ab1
Spark 3.4: BaseMetadataTable should respect the base table properties
roryqi Aug 30, 2023
bc51208
fix
roryqi Aug 30, 2023
a854c87
trigger
roryqi Aug 30, 2023
f9ebf65
Other method use table() instead of table, keep consistent
roryqi Aug 31, 2023
9d89280
fix
roryqi Sep 12, 2023
be279f7
fix
roryqi Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions core/src/main/java/org/apache/iceberg/PositionDeletesTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@
import com.github.benmanes.caffeine.cache.Caffeine;
import com.github.benmanes.caffeine.cache.LoadingCache;
import java.io.IOException;
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.function.Function;
import java.util.stream.Collectors;
import org.apache.iceberg.expressions.Expression;
import org.apache.iceberg.expressions.Expressions;
import org.apache.iceberg.expressions.ManifestEvaluator;
Expand Down Expand Up @@ -93,6 +95,16 @@ public Map<Integer, PartitionSpec> specs() {
return specs;
}

@Override
public Map<String, String> properties() {
// The write properties are needed by PositionDeletesRewriteAction,
// these properties should respect the ones of BaseTable.
return Collections.unmodifiableMap(
table().properties().entrySet().stream()
.filter(entry -> entry.getKey().startsWith("write."))
Copy link
Copy Markdown
Contributor Author

@roryqi roryqi Sep 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find that all the write properties are needed for our PositionDeletesRewriteAction. So I choose to match the key prefix here instead of copying some specific entries.

.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue)));
}

private Schema calculateSchema() {
Types.StructType partitionType = Partitioning.partitionType(table());
Schema result =
Expand Down
26 changes: 12 additions & 14 deletions spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestCompressionSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,20 +182,18 @@ public void testWriteDataWithDifferentSetting() throws Exception {
.isEqualToIgnoringCase(properties.get(COMPRESSION_CODEC));
}

if (PARQUET.equals(format)) {
SparkActions.get(spark)
.rewritePositionDeletes(table)
.option(SizeBasedFileRewriter.REWRITE_ALL, "true")
.execute();
table.refresh();
deleteManifestFiles = table.currentSnapshot().deleteManifests(table.io());
try (ManifestReader<DeleteFile> reader =
ManifestFiles.readDeleteManifest(deleteManifestFiles.get(0), table.io(), specMap)) {
DeleteFile file = reader.iterator().next();
InputFile inputFile = table.io().newInputFile(file.path().toString());
Assertions.assertThat(getCompressionType(inputFile))
.isEqualToIgnoringCase(properties.get(COMPRESSION_CODEC));
}
SparkActions.get(spark)
.rewritePositionDeletes(table)
.option(SizeBasedFileRewriter.REWRITE_ALL, "true")
.execute();
table.refresh();
deleteManifestFiles = table.currentSnapshot().deleteManifests(table.io());
try (ManifestReader<DeleteFile> reader =
ManifestFiles.readDeleteManifest(deleteManifestFiles.get(0), table.io(), specMap)) {
DeleteFile file = reader.iterator().next();
InputFile inputFile = table.io().newInputFile(file.path().toString());
Assertions.assertThat(getCompressionType(inputFile))
.isEqualToIgnoringCase(properties.get(COMPRESSION_CODEC));
}
}

Expand Down