Skip to content

[WIP] Spark 3.4: The properties of PositionDeletesTable should respect the properties of BaseTable #8429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roryqi wants to merge 4 commits into from
Closed

[WIP] Spark 3.4: The properties of PositionDeletesTable should respect the properties of BaseTable #8429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46b1ab1
Spark 3.4: BaseMetadataTable should respect the base table properties
roryqi Aug 30, 2023
182a738
[WIP] Spark 3.4: PositionDeletesTable properties should respect the b…
roryqi Aug 30, 2023
b5fce2c
fix
roryqi Aug 30, 2023
f600ed2
fix
roryqi Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/main/java/org/apache/iceberg/PositionDeletesTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@ public Map<Integer, PartitionSpec> specs() {
return specs;
}

@Override
public Map<String, String> properties() {
return table().properties();
}

private Schema calculateSchema() {
Types.StructType partitionType = Partitioning.partitionType(table());
Schema result =
Expand Down
26 changes: 12 additions & 14 deletions spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/TestCompressionSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,20 +182,18 @@ public void testWriteDataWithDifferentSetting() throws Exception {
.isEqualToIgnoringCase(properties.get(COMPRESSION_CODEC));
}

if (PARQUET.equals(format)) {
SparkActions.get(spark)
.rewritePositionDeletes(table)
.option(SizeBasedFileRewriter.REWRITE_ALL, "true")
.execute();
table.refresh();
deleteManifestFiles = table.currentSnapshot().deleteManifests(table.io());
try (ManifestReader<DeleteFile> reader =
ManifestFiles.readDeleteManifest(deleteManifestFiles.get(0), table.io(), specMap)) {
DeleteFile file = reader.iterator().next();
InputFile inputFile = table.io().newInputFile(file.path().toString());
Assertions.assertThat(getCompressionType(inputFile))
.isEqualToIgnoringCase(properties.get(COMPRESSION_CODEC));
}
SparkActions.get(spark)
.rewritePositionDeletes(table)
.option(SizeBasedFileRewriter.REWRITE_ALL, "true")
.execute();
table.refresh();
deleteManifestFiles = table.currentSnapshot().deleteManifests(table.io());
try (ManifestReader<DeleteFile> reader =
ManifestFiles.readDeleteManifest(deleteManifestFiles.get(0), table.io(), specMap)) {
DeleteFile file = reader.iterator().next();
InputFile inputFile = table.io().newInputFile(file.path().toString());
Assertions.assertThat(getCompressionType(inputFile))
.isEqualToIgnoringCase(properties.get(COMPRESSION_CODEC));
}
}

Expand Down