Make FanoutWriter a package public class #8581
Conversation
| * this writer only when clustering by spec/partition is not possible (e.g. streaming). | ||
| */ | ||
| abstract class FanoutWriter<T, R> implements PartitioningWriter<T, R> { | ||
| public abstract class FanoutWriter<T, R> implements PartitioningWriter<T, R> { |
There was a problem hiding this comment.
It was actually done on purpose as it is a parent class. We expose FanoutDataWriter and related implementations. The same is also true for ClusteredWriter. Is there a particular need to expose this class? Is it something generic enough to live in the repo itself?
There was a problem hiding this comment.
The only difference between FanoutWriter and FanoutDataWriter is that the latter enforces the use of RollingDataWriter and adds quite a bit of complexity. I'd argue that both are equally useful and FanoutWriter is much easier to implement and does not enforce things like file name format for example.
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
2 participants
It looks like FanoutWriter is not public by mistake. Right now the only way to implement FanoutWriter is to implement FanoutDataWriter which is not ideal. The analogous class PartitionedFanoutWriter was made public in this PR: #1774