Flink 1.17: Use awaitility instead of Thread.sleep() #8852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
awaitility-flink
branch
from
fb200e8 to
d31e88d
Compare
nastra
changed the title
nastra
force-pushed
the
awaitility-flink
branch
from
d31e88d to
6f5ac87
Compare
nk1506
reviewed
Oct 17, 2023
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java
Outdated
Show resolved
Hide resolved
.../v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
awaitility-flink
branch
from
6f5ac87 to
eb6f9c7
Compare
This was referenced Oct 17, 2023
nk1506
approved these changes
Oct 17, 2023
amogh-jahagirdar
approved these changes
Oct 17, 2023
Contributor
Author
|
thanks for reviewing @amogh-jahagirdar and @nk1506. @nk1506 would you be interested in backporting this to older Flink versions? |
Contributor
|
Yeah sure @nastra . I will create PR with other versions. |
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Nov 23, 2023
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Nov 23, 2023
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Nov 24, 2023
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Nov 24, 2023
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Nov 24, 2023
pvary
pushed a commit
to pvary/iceberg
that referenced
this pull request
Nov 24, 2023
nastra
pushed a commit
that referenced
this pull request
Nov 24, 2023
mas-chen
pushed a commit
to mas-chen/iceberg
that referenced
this pull request
Jan 9, 2024
rodmeneses
pushed a commit
to rodmeneses/iceberg
that referenced
this pull request
Feb 19, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.