Skip to content

Conversation

@nastra
Copy link
Contributor

@nastra nastra commented Nov 9, 2023

currently depends on #7913

@nastra
Copy link
Contributor Author

nastra commented Nov 9, 2023

The test failures are because the backend catalog in TestRESTCatalog doesn't support views, hence I switched it to InMemoryCatalog in #9014

@nastra nastra force-pushed the views-improve-view-table-detection branch from f20eba4 to 72e2e23 Compare December 5, 2023 16:32
@nastra nastra requested a review from rdblue December 5, 2023 16:33
Copy link
Member

@ajantha-bhat ajantha-bhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdblue rdblue merged commit 7d06af3 into apache:main Dec 10, 2023
@rdblue
Copy link
Contributor

rdblue commented Dec 10, 2023

Thanks for this update!

@nastra nastra deleted the views-improve-view-table-detection branch December 11, 2023 07:36
lisirrx pushed a commit to lisirrx/iceberg that referenced this pull request Jan 4, 2024
zhongyujiang pushed a commit to zhongyujiang/iceberg that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants