Move the currentPath & path methods to the parent class for removing the duplicated codes #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the duplicated codes
rdblue
reviewed
Apr 22, 2020
| return primitiveType.getPrimitiveTypeName() == PrimitiveType.PrimitiveTypeName.INT32; | ||
| } | ||
|
|
||
| public static String[] currentPath(Deque<String> fieldNames) { |
Contributor
There was a problem hiding this comment.
This implementation is too tied to how the Deque is used. I would expect iterating over the object passed in to create the right name, but this assumes it needs to use descendingIterator(). How about updating these methods to accept Iterator<String> instead so that they aren't tightly coupled to the original use?
Member
Author
There was a problem hiding this comment.
It's not appropriate to put the two methods in ParquetUtil.java, I've moved them out of the utility class. Thanks.
Contributor
|
Thanks, @openinx! It looks good except for the confusing behavior of these methods when moved to a utility class. I think we can fix that by altering the method arguments. |
rdblue
added a commit
to rdblue/iceberg
that referenced
this pull request
May 4, 2020
This was referenced May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.