Skip to content

Build: Don't publish iceberg-open-api module #9871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielcweeks merged 1 commit into from
Mar 5, 2024
Merged

Build: Don't publish iceberg-open-api module #9871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions deploy.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ if (project.hasProperty('release') && jdkVersion != '8') {
}

subprojects {
if (it.name == 'iceberg-open-api') {
Copy link
Member

@ajantha-bhat ajantha-bhat Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering do we need project.hasProperty('release') check also here? Because without -Prelease it should work as usual?

Copy link
Contributor Author

@nastra nastra Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also don't want to publish the artifact when running ./gradlew publishToMavenLocal. Exiting early here means we basically don't run any publishing/signing tasks for this particular artifact

// don't publish iceberg-open-api
return
}

def isBom = it.name == 'iceberg-bom'

apply plugin: 'maven-publish'
Expand Down