feat(cpp): Add bazel building and testing infrastructure#2785
feat(cpp): Add bazel building and testing infrastructure#2785slbotbm wants to merge 5 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2785 +/- ##
============================================
- Coverage 68.44% 68.02% -0.43%
- Complexity 656 739 +83
============================================
Files 852 874 +22
Lines 68196 69810 +1614
Branches 59657 60434 +777
============================================
+ Hits 46679 47489 +810
- Misses 19187 19972 +785
- Partials 2330 2349 +19
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Nice work on the infra setup. the CI integration and Bazel config are clean. Two things to fix before merge though: the |
|
@atharvalade thanks for the review! those were some things that had been left over from when I was experimenting with the public interface. I've standardized all of the getter functions and corrected the bazel build file as well. |
|
@hubcio Thanks for the review. I'll address the other two comments after thinking about the best approach |
| fi | ||
| sudo apt-get update --yes | ||
| sudo apt-get install --yes clang-format-18 | ||
| clang-format --version |
There was a problem hiding this comment.
still not properly fixed. you need to call clang-format-18, because if it was installed it'll use system version.
Which issue does this PR close?
Closes #2762
Rationale
What changed?
Adds bazel build system + stub classes and their tests + ci scripts
Local Execution
AI Usage
If AI tools were used, please answer: