feat: add protocol feature flags for conditional compilation#2845
Open
seokjin0414 wants to merge 5 commits intoapache:masterfrom
Open
feat: add protocol feature flags for conditional compilation#2845seokjin0414 wants to merge 5 commits intoapache:masterfrom
seokjin0414 wants to merge 5 commits intoapache:masterfrom
Conversation
hubcio
requested changes
Mar 2, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2845 +/- ##
============================================
- Coverage 67.53% 67.51% -0.02%
Complexity 739 739
============================================
Files 1048 1048
Lines 84103 84145 +42
Branches 60704 60757 +53
============================================
+ Hits 56795 56808 +13
- Misses 24950 24966 +16
- Partials 2358 2371 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Add tcp, quic, websocket feature flags to iggy_common crate. Guard SenderKind variants, constructors, and dispatch macro with #[cfg(feature)] attributes. Make tungstenite optional, gated behind websocket feature. Signed-off-by: shin <sars21@hanmail.net>
Signed-off-by: shin <sars21@hanmail.net>
Add tcp, quic, http, websocket feature flags to server crate. Guard protocol modules, shard fields, task spawning, and handler imports with #[cfg(feature)] attributes. Make axum, tower-http, jsonwebtoken optional behind http feature. Signed-off-by: shin <sars21@hanmail.net>
Add tcp, quic, http, websocket feature flags to SDK crate. Guard client modules, ClientWrapper variants, builder structs, and match arms with #[cfg(feature)] attributes. Extract shared TLS verifier to new tls module for TCP/WebSocket independence. Make transport-specific dependencies optional. Signed-off-by: shin <sars21@hanmail.net>
f7f8e35 to
940a089
Compare
Signed-off-by: shin <sars21@hanmail.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88
Summary
tcp,quic,http,websocketfeature flags to server, SDK, iggy_common, and configs crates#[cfg(feature)]tls/module for tcp/websocket independencecompile_error!guards for zero-protocol buildsDesign
binary_*.rsfiles gated accordinglyVerified
cargo clippy --all-features -D warningscleancargo fmtclean