Conversation
isapego
left a comment
isapego
left a comment
There was a problem hiding this comment.
Looks good overall, but there are few questions inline.
| """ | ||
| from pyignite import AioClient | ||
| from pyignite.api.cluster import cluster_get_state_async, cluster_set_state_async | ||
|
|
There was a problem hiding this comment.
Why is this file even been there?
There was a problem hiding this comment.
I suppose you have added this by mistake and I've missed this on review. I realised that this is file is not used at all while ran test with coverage.
| pass | ||
|
|
||
|
|
||
| class _EventListeners: |
There was a problem hiding this comment.
Is it common practice in Python that there is a separate method for every event? Why won't we just add a event_type field to an event and on_event message to listener? With current approach we need to create new methods for every new event.
There was a problem hiding this comment.
With current approach we need to create new methods for every new event.
Yep, but it is much more convenient to user. Firstly, user should not create these methods by hand. Secondly,
it should not write a bunch if..elif..else code. Plus, python is a dynamic-typed language and there is not much help from IDE when you code such a thing. In current apporach these problems are eliminated.
There was a problem hiding this comment.
Here are the examples of PyCharm IDE help in this case:
- Add new event handler
- Autocomplete fields of event
2 participants
No description provided.