Skip to content

IGNITE-17023 Python thin: Fix supported versions#52

Closed
isapego wants to merge 4 commits intoapache:masterfrom
isapego:ignite-17023
Closed

IGNITE-17023 Python thin: Fix supported versions#52
isapego wants to merge 4 commits intoapache:masterfrom
isapego:ignite-17023

Conversation

@isapego
Copy link
Copy Markdown
Contributor

@isapego isapego commented May 23, 2022

No description provided.

@ivandasch
Copy link
Copy Markdown
Contributor

ivandasch commented May 24, 2022 •
edited
Loading

In general, patch is good.

But it will be great if

  • I suppose that this PR is not a proper place for documentation improvement, I suppose removing mention of 3.6 is more than enough
  • Could you please remove 3.6 from tox.ini and travis.yml and add 3.10
  • Could you please upgrade version of ignite in travis.yml to 2.13? 2.12 was removed from rbc mirror

@ivandasch ivandasch self-requested a review May 24, 2022 07:14
ivandasch
ivandasch requested changes May 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ivandasch ivandasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@asfgit asfgit closed this in ac12197 May 26, 2022
isapego added a commit that referenced this pull request Nov 12, 2024
@isapego @ivandasch
GG-33908 IGNITE-14911 Unify timeouts, add support for datetime.timede…
894a64c 
…lta for expiry_policy (#52)

(cherry picked from commit 92a115c)

Co-authored-by: Ivan Daschinsky <ivandasch@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivandasch ivandasch ivandasch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isapego @ivandasch