IGNITE-13863: Fix Null reading and writing#6
Closed
isapego wants to merge 7 commits intoapache:masterfrom
Closed
Conversation
ivandasch
reviewed
Jan 26, 2021
ivandasch
reviewed
Feb 2, 2021
| @classmethod | ||
| def to_python(cls, ctype_object, *args, **kwargs): | ||
| return ctype_object.type, super().to_python( | ||
| typ = getattr(ctype_object, "type", None) |
Contributor
There was a problem hiding this comment.
Inconsistent naming, may be it's better to use tc_type or 'obj_type'
ivandasch
reviewed
Feb 2, 2021
| class AllTypesObject( | ||
| metaclass=GenericObjectMeta, | ||
| type_name='TestObject', | ||
| schema=OrderedDict([ |
Contributor
There was a problem hiding this comment.
too many repeats.
def camel_to_snake(name):
name = re.sub('(.)([A-Z][a-z]+)', r'\1_\2', name)
return re.sub('([a-z0-9])([A-Z])', r'\1_\2', name).lower()
fields = [(camel_to_snake(type_.__name__, type_) for type_ in [ByteObject,... ]]
class AllTypesObject(schema=OrderedDict(fields)):
pass
for field,_ in fields:
setattr(obj, field, None)
isapego
pushed a commit
to isapego/ignite-python-thin-client
that referenced
this pull request
Feb 10, 2021
… composite keys (apache#6) * GG-27261 Python client incorrect hash code calculation for classes as composite keys Co-authored-by: Aleksandr Shapkin <lexwert@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.