IGNITE-14057 Support big-endian systems#7
Closed
isapego wants to merge 3 commits intoapache:masterfrom
Closed
Conversation
ivandasch
reviewed
Jan 27, 2021
ivandasch
reviewed
Jan 27, 2021
| return Primitive.fix_endianness(bytes(cls.c_type(value))) | ||
|
|
||
| @staticmethod | ||
| def fix_endianness(buf): |
Contributor
There was a problem hiding this comment.
This is too slow
timeit.timeit(lambda: fix_endianness(bytes(ctypes.c_longlong(10000))), number=1000000)
0.679906272000153
timeit.timeit(lambda: struct.pack("<q", 10000), number=1000000)
0.25078236300032586
Fix primitives decoding on big-endian architectures
ivandasch
approved these changes
Jan 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix primitives decoding on big-endian architectures