Skip to content

Leaving empty protected branches to actually disable it#697

Merged
dave2wave merged 1 commit intomainfrom
actually-revert-protected-branches
Apr 12, 2026
Merged

Leaving empty protected branches to actually disable it#697
dave2wave merged 1 commit intomainfrom
actually-revert-protected-branches

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Apr 12, 2026

The protected branches have not been removed by #692 because it just skipped the whole protected brnaches. Empty protected branches should cleanup all of them.

The protected branches have not been removed by #692 because it
just skipped the whole protected brnaches. Empty protected branches
should cleanup all of them.
@potiuk potiuk requested review from dave2wave and raboof April 12, 2026 16:22
Copy link
Copy Markdown
Member

@dave2wave dave2wave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dave2wave dave2wave merged commit eeb6200 into main Apr 12, 2026
6 checks passed
@dave2wave dave2wave deleted the actually-revert-protected-branches branch April 12, 2026 16:26
@raboof
Copy link
Copy Markdown
Member

raboof commented Apr 12, 2026

The protected branches have not been removed by #692 because it just skipped the whole protected brnaches. Empty protected branches should cleanup all of them.

If that were the case then 0233fe3 would not have been possible, right?

No objection to the change, though.

potiuk added a commit that referenced this pull request Apr 12, 2026
Re-enable required PR reviews (1 approval) and status checks
that were reverted in #697.

Generated-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants