Skip to content

dependabot: apply cooldown except for action reviews#712

Merged
potiuk merged 1 commit intoapache:mainfrom
raboof:use-cooldown-except-for-reviews
Apr 15, 2026
Merged

dependabot: apply cooldown except for action reviews#712
potiuk merged 1 commit intoapache:mainfrom
raboof:use-cooldown-except-for-reviews

Conversation

@raboof
Copy link
Copy Markdown
Member

@raboof raboof commented Apr 14, 2026

Fixes #683

Sadly GHA are not so easy to test, so this might take some rounds to get right :)

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Apr 14, 2026

Sadly GHA are not so easy to test, so this might take some rounds to get right :)

Try claude.... (and not joking about it) - for things like renaming workflows etc. It's actually very good in findng all the places that needs to get updated :)

@raboof raboof force-pushed the use-cooldown-except-for-reviews branch 6 times, most recently from a8c0087 to 2f71107 Compare April 14, 2026 22:00
@raboof
Copy link
Copy Markdown
Member Author

raboof commented Apr 14, 2026

Fixed a few things, now seems OK to me.

That "Verify Dependabot Action Build" is skipped makes sense since this is not a dependabot PR
That "Check for transitive failures in current latest actions" fails is expected, that's #606

Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on my earlier review — turning the actionable items into inline suggestions. Three of these (the using: "composite" header, the update_composite_action.yml typo, and the open-pull-requests-limit: 50 placement) are blockers in my opinion; the rest are polish.

Comment thread gateway/gateway.py
Comment thread gateway/gateway.py Outdated
Comment thread .github/workflows/update_composite_actions.yml
Comment thread .github/workflows/update_composite_actions.yml
Comment thread .github/dependabot.yml
Comment thread .github/dependabot.yml Outdated
@raboof raboof force-pushed the use-cooldown-except-for-reviews branch 3 times, most recently from bed8e23 to 29e75af Compare April 14, 2026 23:41
@raboof raboof force-pushed the use-cooldown-except-for-reviews branch from 29e75af to e488982 Compare April 14, 2026 23:43
@raboof raboof requested a review from potiuk April 14, 2026 23:45
Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review on e488982 — all three blockers and every polish item from the previous pass are addressed. Confirmed against the new HEAD:

Blockers

  • gateway/gateway.py:183using: "composite" is now in the header literal.
  • update_composite_action.yml — the singular/plural mismatch is resolved by renaming the file (the opposite direction from my suggestion, which works just as well since the in-file references are now consistent).
  • .github/dependabot.ymlopen-pull-requests-limit: 50 moved onto the allowlist-review block.

Polish

  • update_refs: dummy_stepscomposite_steps (signature + docstring + body).
  • update_actions: docstring Path to the dummy workflow filePath to the composite action file.
  • update_workflow: dummy_pathcomposite_action_path, docstring updated, and write_str call fixed to match.
  • ✅ Bonus: name: Update Dummy workflowname: Update Approved Patterns and Composite Action.

Still open (non-blocking, from the prose review)

  • cpp-linter/cpp-linter-action >=2.16 ignore: is only on the allowlist-review block. In practice it's fine today (the action isn't uses:-d anywhere in the real workflow tree), but if that ever changes the ignore won't apply — worth a durable comment or a duplicated ignore: on the second block.
  • The leafo/gh-actions-luarocks re-ordering in actions.yml is unrelated to the cooldown refactor. Consider splitting it out for a cleaner history, or at least calling it out in the PR description.
  • Optional: a one-line snapshot test asserting 'using: "composite"' in generate_composite_action({}) so the regression caught here cannot sneak back in.

LGTM apart from those nits.

@potiuk potiuk merged commit e70372a into apache:main Apr 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determine recommendations for cooldown periods

2 participants