Skip to content

Cpp client supports visual studio 2026#17218

Merged
jt2594838 merged 4 commits intomasterfrom
cpp_client_supports_vs2026
Mar 11, 2026
Merged

Cpp client supports visual studio 2026#17218
jt2594838 merged 4 commits intomasterfrom
cpp_client_supports_vs2026

Conversation

@HTHou
Copy link
Contributor

@HTHou HTHou commented Feb 24, 2026

This pull request updates the build configuration and dependencies for the C++ client and its example, primarily to use the newer cmake-maven-plugin and improve compatibility with Windows environments, including the addition of Windows 2025 support. The most important changes are grouped below:

Build and Plugin Updates:

  • Replaced the com.googlecode.cmake-maven-project plugin with io.github.cmake-maven-plugin across pom.xml, iotdb-client/client-cpp/pom.xml, and example/client-cpp-example/pom.xml, and updated the plugin version from 3.29.3-b2 to 4.2.3-b1 in the root pom.xml. [1] [2] [3] [4]
  • Changed configuration property names from targetPath and buildDirectory to projectDirectory in plugin executions, and updated test skipping logic to use ${maven.test.skip} instead of ${ctest.skip.tests}. [1] [2] [3] [4]

Windows Build Improvements:

  • Added windows-2025-vs2026 to the CI matrix in .github/workflows/multi-language-client.yml, and included a conditional step to use the Visual Studio 18 2026 CMake generator for this environment. [1] [2]
  • Updated Windows-specific script properties in iotdb-client/client-cpp/pom.xml to reference scripts within a windows/ subdirectory.

Maven Wrapper Update:

  • Upgraded the Maven wrapper version from 3.9.6 to 3.9.12 in .mvn/wrapper/maven-wrapper.properties.

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.70%. Comparing base (9041e60) to head (f43344b).
⚠️ Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17218      +/-   ##
============================================
+ Coverage     39.50%   39.70%   +0.19%     
  Complexity      282      282              
============================================
  Files          5101     5101              
  Lines        341899   341925      +26     
  Branches      43526    43527       +1     
============================================
+ Hits         135078   135770     +692     
+ Misses       206821   206155     -666     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@hongzhi-gao
Copy link
Contributor

LGTM

@jt2594838 jt2594838 merged commit ea3cc3c into master Mar 11, 2026
38 checks passed
@HTHou HTHou deleted the cpp_client_supports_vs2026 branch March 11, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants