Skip to content

Support aggregation push-down optimize for table view of non aligned series #17294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wei-hao-Li wants to merge 7 commits into
base: master
Choose a base branch
from
+933 −82

fix finally

17a4559
Select commit
Loading
Failed to load commit list.
Open

Support aggregation push-down optimize for table view of non aligned series #17294

fix finally
17a4559
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 13, 2026 in 2m 56s

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 873 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 121 to 64, Complexity from 20 to 14, Nesting Level from 3 to 2, Number of Variables from 21 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ7&open=AZziqPEpRDGblgXWVoZ7&pullRequest=17294

Check warning on line 2959 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/TableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzmHNmj0NXBYLQX6mst&open=AZzmHNmj0NXBYLQX6mst&pullRequest=17294

Check warning on line 36 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/NonAlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This class has 7 parents which is greater than 5 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqOxIRDGblgXWVoZx&open=AZziqOxIRDGblgXWVoZx&pullRequest=17294

Check failure on line 1249 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 33 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ5&open=AZziqPEpRDGblgXWVoZ5&pullRequest=17294

Check warning on line 733 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/AbstractAggTableScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCdguHjumTnDTP_&open=AZzkgUCdguHjumTnDTP_&pullRequest=17294

Check failure on line 90 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/AlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this "clone" implementation; use a copy constructor or copy factory instead. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPDyRDGblgXWVoZ3&open=AZziqPDyRDGblgXWVoZ3&pullRequest=17294

Check warning on line 113 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/TreeNonAlignedDeviceViewAggregationScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'Exception'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCmguHjumTnDTQF&open=AZzkgUCmguHjumTnDTQF&pullRequest=17294

Check warning on line 197 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/AbstractAggTableScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'Exception'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCdguHjumTnDTQA&open=AZzkgUCdguHjumTnDTQA&pullRequest=17294

Check warning on line 3928 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/TableOperatorGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 71 to 64, Complexity from 33 to 14, Nesting Level from 4 to 2, Number of Variables from 12 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgTyLguHjumTnDTP8&open=AZzkgTyLguHjumTnDTP8&pullRequest=17294

Check warning on line 1701 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 111 to 64, Complexity from 19 to 14, Nesting Level from 4 to 2, Number of Variables from 22 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ9&open=AZziqPEpRDGblgXWVoZ9&pullRequest=17294

Check warning on line 108 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/TreeNonAlignedDeviceViewAggregationScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCmguHjumTnDTQC&open=AZzkgUCmguHjumTnDTQC&pullRequest=17294

Check failure on line 197 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/AbstractAggTableScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCdguHjumTnDTP-&open=AZzkgUCdguHjumTnDTP-&pullRequest=17294

Check warning on line 1264 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Distance between variable 'needSplit' declaration and its first usage is 7, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ-&open=AZziqPEpRDGblgXWVoZ-&pullRequest=17294

Check failure on line 90 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/NonAlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this "clone" implementation; use a copy constructor or copy factory instead. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqOxIRDGblgXWVoZz&open=AZziqOxIRDGblgXWVoZz&pullRequest=17294

Check warning on line 163 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/TreeNonAlignedDeviceViewAggregationScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Single-line Javadoc comment should be multi-line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCmguHjumTnDTQH&open=AZzkgUCmguHjumTnDTQH&pullRequest=17294

Check warning on line 163 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/TreeNonAlignedDeviceViewAggregationScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

First sentence of Javadoc is missing an ending period. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCmguHjumTnDTQG&open=AZzkgUCmguHjumTnDTQG&pullRequest=17294

Check warning on line 159 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/LastQueryAggTableScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'Exception'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUC_guHjumTnDTQJ&open=AZzkgUC_guHjumTnDTQJ&pullRequest=17294

Check warning on line 733 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/AbstractAggTableScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace generic exceptions with specific library exceptions or a custom exception. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCdguHjumTnDTP9&open=AZzkgUCdguHjumTnDTP9&pullRequest=17294

Check warning on line 58 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/NonAlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Abbreviation in name 'treeDBName' must contain no more than '2' consecutive capital letters. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqOxIRDGblgXWVoZ0&open=AZziqOxIRDGblgXWVoZ0&pullRequest=17294

Check warning on line 90 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/AlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use super.clone() to create and seed the cloned instance to be returned. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPDyRDGblgXWVoZ2&open=AZziqPDyRDGblgXWVoZ2&pullRequest=17294

Check warning on line 41 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/TreeNonAlignedDeviceViewAggregationScanOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This class has 6 parents which is greater than 5 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZzkgUCmguHjumTnDTQB&open=AZzkgUCmguHjumTnDTQB&pullRequest=17294

Check warning on line 36 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/AlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This class has 7 parents which is greater than 5 authorized. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPDyRDGblgXWVoZ1&open=AZziqPDyRDGblgXWVoZ1&pullRequest=17294

Check warning on line 90 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/NonAlignedAggregationTreeDeviceViewScanNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use super.clone() to create and seed the cloned instance to be returned. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqOxIRDGblgXWVoZy&open=AZziqOxIRDGblgXWVoZy&pullRequest=17294

Check warning on line 310 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 65 to 64, Complexity from 15 to 14, Nesting Level from 5 to 2, Number of Variables from 16 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ6&open=AZziqPEpRDGblgXWVoZ6&pullRequest=17294

Check warning on line 1249 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 139 to 64, Complexity from 21 to 14, Nesting Level from 3 to 2, Number of Variables from 26 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZziqPEpRDGblgXWVoZ8&open=AZziqPEpRDGblgXWVoZ8&pullRequest=17294
View more details on SonarQubeCloud