JAMES-4166 JMAP search: drop scroll search, use from/size pagination and collapse by messageId #2928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and collapse by messageId
…et onto the search engine
chibenwa
reviewed
Jan 30, 2026
|
|
||
| import com.google.common.base.Preconditions; | ||
|
|
||
| public record SearchOptions(long offset, long limit) { |
Contributor
There was a problem hiding this comment.
I think ze have a strong type for Limit, I believe we should use it.
A strong typee for offset would also be nice, it likely exist.
chibenwa
reviewed
Jan 30, 2026
| int offset = Math.toIntExact(searchOptions.offset()); | ||
| int limit = Math.toIntExact(searchOptions.limit()); | ||
|
|
||
| return searcher.searchCollapsedByMessageId(mailboxIds, searchQuery, offset, limit, MESSAGE_ID_FIELD, !SEARCH_HIGHLIGHT) |
Contributor
There was a problem hiding this comment.
Please pass Search Options to the parameter of the searcher stuff
chibenwa
reviewed
Jan 30, 2026
Comment on lines
-791
to
+792
| limit) | ||
| SearchOptions.limit(limit)) |
chibenwa
reviewed
Jan 30, 2026
Contributor
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
Nitpicks along the way but IMO it really goes into the right direction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, modify the search API with SearchOptions and push the offset onto the search engine.