MINOR: AbstractCoordinatorTest should close coordinator explicitly#10001
Merged
chia7712 merged 2 commits intoapache:trunkfrom Jan 30, 2021
Merged
MINOR: AbstractCoordinatorTest should close coordinator explicitly#10001chia7712 merged 2 commits intoapache:trunkfrom
chia7712 merged 2 commits intoapache:trunkfrom
Conversation
hachikuji
approved these changes
Jan 29, 2021
Contributor
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. Left a minor suggestion.
Just a couple minutes earlier and you could have gotten PR 10,000!
Member
Author
|
the flaky is traced by #9777 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this issue when digging into some flaky by JVM profiler.
AbstractCoordinatorTestdoes not close coordinator so it can cause a lot of idle heartbeat threads in the following tests.I don't observe the relationship between this issue and flaky. However, it seems to me explicitly releasing idle resource is always a good pattern.
Committer Checklist (excluded from commit message)