MINOR: Refactor return statement and log info

[tang7526]

• Invoke method only conditionally.
• No need to call "toString()" method as formatting and string conversion is done by the Formatter.

before

log.info("Successfully validated token with principal {}: {}", unsecuredJwt.principalName(), unsecuredJwt.claims().toString());

after

if (log.isInfoEnabled()) {
    log.info("Successfully validated token with principal {}: {}", unsecuredJwt.principalName(), unsecuredJwt.claims());
}

• Immediately return the expression instead of assigning it to the temporary variable.

before

String principalClaimName = principalClaimNameValue != null && !principalClaimNameValue.trim().isEmpty()
        ? principalClaimNameValue.trim()
        : "sub";
return principalClaimName;

after

return principalClaimNameValue != null && !principalClaimNameValue.trim().isEmpty()
        ? principalClaimNameValue.trim()
        : "sub";

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[chia7712]

@tang7526 Thanks for your patch. Left some minor comments.

[chia7712]

Is this condition check necessary? It is rare in code base.

[tang7526]

OK, I think you are right. We do not need condition check in here. I already revert it.

[chia7712]

How about adding a helper method to check both "null" and "empty"?

[tang7526]

Done.

[tombentley]

For me the isNotBlank() adds no value. These could just be added to Utils, rather than adding the new class. Also: Add javadoc.

[tang7526]

@tombentley Thanks for your opinion. I have removed isNotBlank() and added javadoc.

[chia7712]

@tang7526 Thanks for your patch. LGTM

[chia7712]

The test failure is related to #10024

@tang7526 Could you merge trunk to trigger QA again?

[tang7526]

The test failure is related to #10024

@tang7526 Could you merge trunk to trigger QA again?

@chia7712 Done

[chia7712]

How about applying this helper method to code base?

[tang7526]

How about applying this helper method to code base?
@chia7712 OK. I will do it on next PR.