MINOR: Word count should account for extra whitespaces between words#10044
Merged
mjsax merged 1 commit intoapache:trunkfrom Feb 5, 2021
Merged
MINOR: Word count should account for extra whitespaces between words#10044mjsax merged 1 commit intoapache:trunkfrom
mjsax merged 1 commit intoapache:trunkfrom
Conversation
Signed-off-by: Arjun Satish <arjun@confluent.io>
mjsax
approved these changes
Feb 3, 2021
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
LGTM. Can merge after Jenkins passed.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the word count demo only accounts for single whitespaces between words. This fix uses a more generic regex to skip multiple spaces or tabs that may occur between words. Corresponding unit tests were updated.
Also, the quickstart docs already use the correct regex.
Signed-off-by: Arjun Satish arjun@confluent.io
Committer Checklist (excluded from commit message)