Adding documentation for KIP-614#10051
Merged
vvcephei merged 2 commits intoapache:trunkfrom Feb 24, 2021
Merged
Conversation
3 tasks
cadonna
reviewed
Feb 4, 2021
Member
cadonna
left a comment
cadonna
left a comment
There was a problem hiding this comment.
Thanks for the docs, @vamossagar12!
You need to move the paragraph one section up.
vamossagar12
force-pushed
the
kip-614-doc
branch
from
c46de0d to
6a38499
Compare
Contributor
Author
|
done. |
cadonna
approved these changes
Feb 5, 2021
Member
cadonna
left a comment
cadonna
left a comment
There was a problem hiding this comment.
@vamossagar12, Thanks a lot!
LGTM!
Member
|
@vamossagar12, you need to rebase your PR. |
Member
|
Call for committer review: @guozhangwang |
vamossagar12
force-pushed
the
kip-614-doc
branch
from
6a38499 to
49b32b0
Compare
Contributor
Author
|
@cadonna Done. |
vvcephei
approved these changes
Feb 24, 2021
Contributor
vvcephei
left a comment
vvcephei
left a comment
There was a problem hiding this comment.
Thanks, @vamossagar12 !
Contributor
|
Fixed the merge conflict. |
vvcephei
pushed a commit
that referenced
this pull request
Feb 24, 2021
Reviewers: Bruno Cadonna <bruno@confluent.io>, John Roesler <vvcephei@apache.org>
Contributor
|
Merged to 2.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)