KAFKA-12298: Create LeaderAndIsrRequestBenchmark#10071
Closed
jolshan wants to merge 4 commits intoapache:trunkfrom
Closed
KAFKA-12298: Create LeaderAndIsrRequestBenchmark#10071jolshan wants to merge 4 commits intoapache:trunkfrom
jolshan wants to merge 4 commits intoapache:trunkfrom
Conversation
This was referenced Feb 10, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it would be useful to check how the changes to LeaderAndIsrRequests (for KIP-516) affect the handling of the request. This benchmark builds a LeaderAndIsrRequest and calls
kafkaApis.handleLeaderAndIsrRequest. Other benchmarks for this type of request could be added here as well.I also slightly changed the MetadataRequestBenchmark since I noticed that the MetadataCache used in that benchmark did not add topic IDs.
Committer Checklist (excluded from commit message)