MINOR: Rename DecommissionBrokers to UnregisterBrokers#10084
Merged
cmccabe merged 4 commits intoapache:trunkfrom Feb 10, 2021
Merged
MINOR: Rename DecommissionBrokers to UnregisterBrokers#10084cmccabe merged 4 commits intoapache:trunkfrom
cmccabe merged 4 commits intoapache:trunkfrom
Conversation
chia7712
reviewed
Feb 9, 2021
ijuma
reviewed
Feb 9, 2021
Member
There was a problem hiding this comment.
@cmccabe We should mark all KIP-500 methods with @Unstable and mention it in the documentation too.
cmccabe
force-pushed
the
decommission_to_unregister
branch
from
eefd12b to
c5f0121
Compare
chia7712
approved these changes
Feb 10, 2021
ijuma
reviewed
Feb 10, 2021
Member
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Thanks for the PR. A couple of comments below. Also, we should update the PR description to describe the other changes we include in the PR besides the rename.
Member
There was a problem hiding this comment.
"DescribeFeaturesResult" needs to be updated.
Member
There was a problem hiding this comment.
This is a bit confusing since this method can be called when the built-in quorum mode is used too. Or am I missing something?
Contributor
Author
There was a problem hiding this comment.
This method can't be called in built-in quorum mode since the API is forwardable and we will always have a forwarding manager
Member
There was a problem hiding this comment.
Can we add a comment explaining that?
cmccabe
force-pushed
the
decommission_to_unregister
branch
from
c5f0121 to
57a1cff
Compare
ijuma
approved these changes
Feb 10, 2021
Member
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
LGTM after the comment is added and the PR description (and commit message) is updated.
cmccabe
added a commit
that referenced
this pull request
Feb 10, 2021
Rename DecommissionBrokers to UnregisterBrokers. Fix an incorrect JavaDoc comment for the Admin API. Make sure that UNREGISTER_BROKER is marked as forwardable and not as a controller-only API (since it can received by brokers). Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Ismael Juma <ismael@juma.me.uk>
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Feb 14, 2021
…e-allocations-lz4 * apache-github/trunk: (118 commits) KAFKA-12327: Remove MethodHandle usage in CompressionType (apache#10123) KAFKA-12297: Make MockProducer return RecordMetadata with values as per contract MINOR: Update zstd and use classes with no finalizers (apache#10120) KAFKA-12326: Corrected regresion in MirrorMaker 2 executable introduced with KAFKA-10021 (apache#10122) KAFKA-12321 the comparison function for uuid type should be 'equals' rather than '==' (apache#10098) MINOR: Add FetchSnapshot API doc in KafkaRaftClient (apache#10097) MINOR: KIP-631 KafkaConfig fixes and improvements (apache#10114) KAFKA-12272: Fix commit-interval metrics (apache#10102) MINOR: Improve confusing admin client shutdown logging (apache#10107) MINOR: Add BrokerMetadataListener (apache#10111) MINOR: Support Raft-based metadata quorums in system tests (apache#10093) MINOR: add the MetaLogListener, LocalLogManager, and Controller interface. (apache#10106) MINOR: Introduce the KIP-500 Broker lifecycle manager (apache#10095) MINOR: Remove always-passing validation in TestRecordTest#testProducerRecord (apache#9930) KAFKA-5235: GetOffsetShell: Support for multiple topics and consumer configuration override (KIP-635) (apache#9430) MINOR: Prevent creating partition.metadata until ID can be written (apache#10041) MINOR: Add RaftReplicaManager (apache#10069) MINOR: Add ClientQuotaMetadataManager for processing QuotaRecord (apache#10101) MINOR: Rename DecommissionBrokers to UnregisterBrokers (apache#10084) MINOR: KafkaBroker.brokerState should be volatile instead of AtomicReference (apache#10080) ... clients/src/main/java/org/apache/kafka/common/record/CompressionType.java core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename DecommissionBrokers to UnregisterBrokers. Fix an incorrect JavaDoc comment for the Admin API. Make sure that UNREGISTER_BROKER is marked as forwardable and not as a controller-only API (since it can received by brokers).