Add BrokerMetadataListener and related classes#10090
Closed
mumrah wants to merge 2 commits intoapache:trunkfrom
Closed
Add BrokerMetadataListener and related classes#10090mumrah wants to merge 2 commits intoapache:trunkfrom
mumrah wants to merge 2 commits intoapache:trunkfrom
Conversation
Comment on lines
100
to
104
Contributor
There was a problem hiding this comment.
Perhaps not to resolve now, but I think error conditions like this might need more thought. Should the broker die? If so, how would the broker ever come back up if it can't get past a particular batch? But what is the impact of not processing the remaining messages in a batch, and is that always acceptable or just sometimes acceptable? Do we need metrics to track these error events? It seems an error log message might not be sufficient?
mumrah
force-pushed
the
upstream-broker-quota-processor
branch
from
9811dcb to
16302f8
Compare
mumrah
changed the title
mumrah
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds BrokerMetadataListener which is responsible for processing metadata records received by the broker when running in Raft mode.
Note that several files in this PR are also included in #10106 which will get merged to trunk first.