MINOR: correct the error message of validating uint32#10193
Merged
chia7712 merged 3 commits intoapache:trunkfrom Mar 2, 2021
Merged
MINOR: correct the error message of validating uint32#10193chia7712 merged 3 commits intoapache:trunkfrom
chia7712 merged 3 commits intoapache:trunkfrom
Conversation
tombentley
reviewed
Mar 1, 2021
| return (Long) item; | ||
| else | ||
| throw new SchemaException(item + " is not a Long."); | ||
| throw new SchemaException(item + " is not an unsigned integer."); |
Member
There was a problem hiding this comment.
This would be inconsistent with the other messages, which refer to Java types. It's a condition on the Java type, so including it in the message is reasonable imho.
Suggested change
| throw new SchemaException(item + " is not an unsigned integer."); | |
| throw new SchemaException(item + " is not a Long (encoding an unsigned integer)."); |
Member
There was a problem hiding this comment.
Though now I look at the message for UINT16 I see it would be consistent with that. Still I think because there are two types involved here, the Java type and the network type, including both is clearest.
Member
Author
There was a problem hiding this comment.
make sense. will copy that.
tombentley
approved these changes
Mar 2, 2021
ijuma
reviewed
Mar 2, 2021
| return (Long) item; | ||
| else | ||
| throw new SchemaException(item + " is not a Long."); | ||
| throw new SchemaException(item + " is not an a Long (encoding an unsigned integer)."); |
Member
There was a problem hiding this comment.
Also, I think it reads a bit weird. Not clear that "encoding an unsigned integer" in brackets means when reading the message.
Member
Author
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Mar 2, 2021
* apache-github/trunk: (37 commits) KAFKA-10357: Extract setup of changelog from Streams partition assignor (apache#10163) KAFKA-10251: increase timeout for consuming records (apache#10228) KAFKA-12394; Return `TOPIC_AUTHORIZATION_FAILED` in delete topic response if no describe permission (apache#10223) MINOR: Disable transactional/idempotent system tests for Raft quorums (apache#10224) KAFKA-10766: Unit test cases for RocksDBRangeIterator (apache#9717) KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore (apache#10052) KAFKA-12268: Implement task idling semantics via currentLag API (apache#10137) MINOR: Time and log producer state recovery phases (apache#10241) MINOR: correct the error message of validating uint32 (apache#10193) MINOR: Format the revoking active log output in `StreamsPartitionAssignor` (apache#10242) KAFKA-12323 Follow-up: Refactor the unit test a bit (apache#10205) MINOR: Remove stack trace of the lock exception in a debug log4j (apache#10231) MINOR: Word count should account for extra whitespaces between words (apache#10229) MINOR; Small refactor in `GroupMetadata` (apache#10236) KAFKA-10340: Proactively close producer when cancelling source tasks (apache#10016) KAFKA-12329; kafka-reassign-partitions command should give a better error message when a topic does not exist (apache#10141) KAFKA-12254: Ensure MM2 creates topics with source topic configs (apache#10217) MINOR: fix kafka-metadata-shell.sh (apache#10226) KAFKA-12374: Add missing config sasl.mechanism.controller.protocol (apache#10199) KAFKA-10101: Fix edge cases in Log.recoverLog and LogManager.loadLogs (apache#8812) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as title
Committer Checklist (excluded from commit message)