KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller#10194
KAFKA-12365; Disable APIs not supported by KIP-500 broker/controller#10194hachikuji merged 5 commits intoapache:trunkfrom
Conversation
|
Note I'm doing a pass over the other APIs that should be disabled for now. For example, the reassignment APIs are not yet supported. I will probably just generalize this patch to cover all of them. |
|
The approach LGTM to me. Can you also disable the relevant system test(s) in this PR? Agree that we need to disable a few more things -- reassignment is one |
hachikuji
force-pushed
the
KAFKA-12365
branch
from
cb80578 to
7e65dcb
Compare
hachikuji
changed the title
hachikuji
force-pushed
the
KAFKA-12365
branch
from
7e65dcb to
77f86c6
Compare
| "apiKey": 48, | ||
| "type": "request", | ||
| "listeners": ["zkBroker", "broker"], | ||
| "listeners": ["zkBroker"], |
There was a problem hiding this comment.
describeClientQuotas is implemented for kip-500 already (on the broker)
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmm... looking at trunk, it looks like there are some changes from the KIP-500 branch that didn't make it over. handleDescribeClientQuotasRequest did work in the kip-500 branch. Anyway, at this point, I think we should just disable it and put client quotas support on the TODO list for the next release (sigh)
| } | ||
| new ApiVersionsResponse(data) | ||
| } else { | ||
| apiVersionManager.apiVersionResponse(requestThrottleMs) |
There was a problem hiding this comment.
I think we do need to fill in the feature fields eventually. But for 2.8, this is OK.
There was a problem hiding this comment.
Right. I think the change makes sense in any case since the feature logic will end up getting handled by ApiVersionManager (as we do with the broker).
There was a problem hiding this comment.
agreed. we will have to have some way for the controller to update those fields in ApiVersionsManager (possibly an atomic / volatile field or something).
…10194) This patch updates request `listeners` tags to be in line with what the KIP-500 broker/controller support today. We will re-enable these APIs as needed once we have added the support. We have also updated `ControllerApis` to use `ApiVersionManager` and simplified the envelope handling logic. Reviewers: Ron Dagostino <rdagostino@confluent.io>, Colin P. McCabe <cmccabe@apache.org>
3 participants
This patch updates request
listenerstags to be in line with what the KIP-500 broker/controller support today. We will re-enable these APIs as needed once we have added the support.I have also updated
ControllerApisto useApiVersionManagerand simplified the envelope handling logic.Committer Checklist (excluded from commit message)