Skip to content

KAFKA-12392: Deprecate the batch-size option in console producer#10202

Closed
kamalcph wants to merge 2 commits intoapache:trunkfrom
kamalcph:console_producer
Closed

KAFKA-12392: Deprecate the batch-size option in console producer#10202
kamalcph wants to merge 2 commits intoapache:trunkfrom
kamalcph:console_producer

Conversation

@kamalcph
Copy link
Copy Markdown
Contributor

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@kamalcph kamalcph changed the title MINOR: Changed the batch-size description as unused in console producer. MINOR: Deprecate the batch-size option in console producer Feb 24, 2021
@tombentley
Copy link
Copy Markdown
Member

Is there a JIRA/KIP where this deprecation was discussed?

@kamalcph
Copy link
Copy Markdown
Contributor Author

kamalcph commented Mar 1, 2021

Is there a JIRA/KIP where this deprecation was discussed?

No, I don't find any and it wasn't discussed. The config is unused so I propose to deprecate it.

@kamalcph kamalcph changed the title MINOR: Deprecate the batch-size option in console producer KAFKA-12392: Deprecate the batch-size option in console producer Mar 1, 2021
@kamalcph
Copy link
Copy Markdown
Contributor Author

kamalcph commented Mar 1, 2021

Filed KAFKA-12392 ticket and opened KIP-717 for discussion.

@kamalcph
Copy link
Copy Markdown
Contributor Author

kamalcph commented Mar 9, 2021

@chia7712 Please take a look.

@chia7712
Copy link
Copy Markdown
Member

@kamalcph thanks for filing KIP. noted that KIP must be accepted first :)

see https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals

@omkreddy
Copy link
Copy Markdown
Contributor

omkreddy commented Mar 17, 2021

its unused since 2.0 release. it looks like we just forgot this config, when we removed old producer code. I think we dont require KIP for this. maybe we can remove the unused config option.

@chia7712
Copy link
Copy Markdown
Member

its unused since 2.0 release. it looks like we just forgot this config, when we removed old producer code. I think we dont require KIP for this. we can remove the unused config option.

Does it produce error if users input batch-size (after we remove the config)? If so, it seems to me the deprecation cycle is requisite as removing the argument could break something (even though the config is unused).

@kamalcph
Copy link
Copy Markdown
Contributor Author

Can we deprecate this config in 2.8 if allowed and remove it in the 3.0 release? WDYT?

@kamalcph
Copy link
Copy Markdown
Contributor Author

kamalcph commented Mar 25, 2021

@chia7712 @tombentley
Can you comment/upvote on the KIP to deprecate this config?

@kamalcph
Copy link
Copy Markdown
Contributor Author

kamalcph commented Mar 6, 2022

Closing this PR, as it's addressed in #11517

@kamalcph kamalcph closed this Mar 6, 2022
@kamalcph kamalcph deleted the console_producer branch March 31, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants