Skip to content

HOTFIX: Controller topic deletion should be atomic#10264

Merged
hachikuji merged 1 commit intoapache:trunkfrom
hachikuji:controller-atomic-deletion
Mar 4, 2021
Merged

HOTFIX: Controller topic deletion should be atomic#10264
hachikuji merged 1 commit intoapache:trunkfrom
hachikuji:controller-atomic-deletion

Conversation

@hachikuji
Copy link
Copy Markdown
Contributor

We merged #10253 and #10184 at about the same time, which caused a build error. Topic deletions should be atomic.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tried ./gradlew clean releaseTarGz locally and it completed fine

@hachikuji
Copy link
Copy Markdown
Contributor Author

I will merge to trunk. The metadata tests are passing locally.

@hachikuji hachikuji merged commit 60a097a into apache:trunk Mar 4, 2021
mumrah pushed a commit that referenced this pull request Mar 4, 2021
Topic deletions should be atomic. This fixes a build error caused by merging of both #10253 and #10184 at about the same time. 

Reviewers: David Arthur <mumrah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants