Skip to content

KAFKA-3352: Avoid DNS reverse lookups#1030

Closed
ijuma wants to merge 1 commit into
apache:trunkfrom
ijuma:kafka-3352-avoid-dns-reverse-look-ups
Closed

KAFKA-3352: Avoid DNS reverse lookups#1030
ijuma wants to merge 1 commit into
apache:trunkfrom
ijuma:kafka-3352-avoid-dns-reverse-look-ups

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Mar 8, 2016

By using getHostString (introduced in Java 7) instead of getHostName.

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Mar 8, 2016

Review by @hachikuji and @gwenshap. Tests pass locally.

@hachikuji
Copy link
Copy Markdown
Contributor

LGTM

@ijuma ijuma force-pushed the kafka-3352-avoid-dns-reverse-look-ups branch from 3da9c7e to 70a2eaf Compare March 9, 2016 10:44
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Mar 9, 2016

@hachikuji, I added a test.

@granthenke
Copy link
Copy Markdown
Member

LGTM

@ijuma ijuma force-pushed the kafka-3352-avoid-dns-reverse-look-ups branch from 70a2eaf to 584dcd2 Compare March 9, 2016 16:52
@ijuma ijuma force-pushed the kafka-3352-avoid-dns-reverse-look-ups branch from 584dcd2 to 3af38a1 Compare March 9, 2016 19:01
@gwenshap
Copy link
Copy Markdown
Contributor

gwenshap commented Mar 9, 2016

LGTM

@asfgit asfgit closed this in 8180803 Mar 9, 2016
@ijuma ijuma deleted the kafka-3352-avoid-dns-reverse-look-ups branch April 5, 2016 09:15
efeg added a commit to efeg/kafka that referenced this pull request Jan 29, 2020
mumrah pushed a commit to mumrah/kafka that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants