KAFKA-3361: Initial protocol documentation page and generation (0.9)#1038
Closed
granthenke wants to merge 2 commits into
Closed
KAFKA-3361: Initial protocol documentation page and generation (0.9)#1038granthenke wants to merge 2 commits into
granthenke wants to merge 2 commits into
Conversation
Member
granthenke
commented
Mar 10, 2016
granthenke
commented
- Moves all generated docs under /docs/generated
- Generates docs for Protocol, Errors, and ApiKeys
- Adds new protocol.html page
- Moves all generated docs under /docs/generated - Generates docs for Protocol, Errors, and ApiKeys - Adds new protocol.html page
| @@ -0,0 +1,163 @@ | |||
| <h3><a id="protocol" href="#protocol">Kafka Wire Protocol</a></h3> | |||
|
|
|||
| <p>This document covers the protocol implemented in Kafka 0.8 and beyond. It is meant to give a readable guide to the protocol that covers the available requests, their binary format, and the proper way to make use of them to implement a client. This document assumes you understand the basic design and terminology described <a href="https://kafka.apache.org/documentation.html#design">here</a></p> | |||
Member
Author
There was a problem hiding this comment.
We did...not sure why the cherry pick missed it. Will fix.
Member
Author
There was a problem hiding this comment.
Updated. Tried to cherry pick both commits at once, must have ignored this one.
asfgit
pushed a commit
that referenced
this pull request
Mar 10, 2016
- Moves all generated docs under /docs/generated - Generates docs for Protocol, Errors, and ApiKeys - Adds new protocol.html page Author: Grant Henke <granthenke@gmail.com> Reviewers: Gwen Shapira Closes #1038 from granthenke/protocol-docs-0.9
Contributor
|
LGTM. Site repo is next? |
Member
Author
|
@gwenshap Yeah, I will work on that tomorrow. |
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
mumrah
pushed a commit
to mumrah/kafka
that referenced
this pull request
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.