MINOR: Add unit test for internal topics#1047
Closed
guozhangwang wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Ping @ymatsuda for reviews. |
Contributor
|
LGTM |
| return standbyTasks; | ||
| } | ||
|
|
||
| public void setInternalTopicManager (InternalTopicManager internalTopicManager) { |
Contributor
There was a problem hiding this comment.
This fails checkstyle because of the space between setInternalTopicManager and the (
Contributor
|
LGTM after fixing checkstyle issues |
Contributor
Author
|
@ewencp Checkstyle issue fixed. Local unit test pass. |
mumrah
pushed a commit
to mumrah/kafka
that referenced
this pull request
Aug 14, 2024
…sts. (apache#1047) * AKCORE-22-4: Initial implementation of ShareSessionHandler (4/N) * Updated ShareFetchRequestManager to prepare requests * Moved ShareFetchMetadata to common/requests --------- Co-authored-by: Andrew Schofield <aschofield@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.