KAFKA-12702: Fix NPE in networkListeners from BrokerServer in 2.8#10586
Merged
chia7712 merged 2 commits intoapache:2.8from Apr 25, 2021
Merged
KAFKA-12702: Fix NPE in networkListeners from BrokerServer in 2.8#10586chia7712 merged 2 commits intoapache:2.8from
chia7712 merged 2 commits intoapache:2.8from
Conversation
Member
Author
|
Dear @chia7712 , I request apply this pr to the 2.8 branch. |
chia7712
reviewed
Apr 22, 2021
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@wenbingshen thanks for your contribution :)
| config.advertisedListeners.foreach { ep => | ||
| networkListeners.add(new Listener(). | ||
| setHost(ep.host). | ||
| setHost(if (Utils.isBlank(ep.host)) InetAddress.getLocalHost.getCanonicalHostName else ep.host). |
Member
There was a problem hiding this comment.
I feel it is ok to check blank manually. It won't bring huge code conflicts.
Member
Author
There was a problem hiding this comment.
I feel it is ok to check blank manually. It won't bring huge code conflicts.
Good suggestion.Submit your feedback. :)
Member
|
@wenbingshen thanks for this backport! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to KAFKA-12702 , 10575
Committer Checklist (excluded from commit message)