KAFKA-3395: prefix job id to internal topic names#1062
Closed
ymatsuda wants to merge 1 commit into
Closed
Conversation
| } | ||
|
|
||
| private static class SinkNodeFactory extends NodeFactory { | ||
| private class SinkNodeFactory extends NodeFactory { |
Contributor
There was a problem hiding this comment.
Why we can no longer make this class static?
Contributor
Author
There was a problem hiding this comment.
To have access to internalTopicNames
Contributor
|
LGTM, unit test passed locally. Merged to trunk. |
efeg
added a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
mumrah
pushed a commit
to mumrah/kafka
that referenced
this pull request
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@guozhangwang