Skip to content

[MINOR]: Remove unused method, redundant in interface definition and add final for object used in sychronization #1063

Closed
Ishiihara wants to merge 1 commit into
apache:trunkfrom
Ishiihara:minor-cleanup
Closed

[MINOR]: Remove unused method, redundant in interface definition and add final for object used in sychronization #1063
Ishiihara wants to merge 1 commit into
apache:trunkfrom
Ishiihara:minor-cleanup

Conversation

@Ishiihara
Copy link
Copy Markdown
Contributor

@guozhangwang Very minor cleanup.

@guozhangwang
Copy link
Copy Markdown
Contributor

@Ishiihara Could you rename the ticket name as MINOR: [description] since it will be used in the commit title?

@Ishiihara Ishiihara changed the title [MINOR] cleanup [MINOR]: Remove unused method, redundant in interface definition and add final for object used in sychronization Mar 14, 2016
@Ishiihara
Copy link
Copy Markdown
Contributor Author

@guozhangwang Added some description.

@guozhangwang
Copy link
Copy Markdown
Contributor

LGTM, merged to trunk.

@asfgit asfgit closed this in cf40acc Mar 14, 2016
@Ishiihara Ishiihara deleted the minor-cleanup branch March 31, 2016 23:22
mumrah pushed a commit to mumrah/kafka that referenced this pull request Aug 14, 2024
)

* AKCORE-26-3: Added handleShareAcknowledgeRequest in KafkaApis.scala

* AKCORE-26-3: Added unit tests for handleShareAcknowledgeRequest in KafkaApisTest.scala

* AKCORE-26-3: refactored some code in handleShareAcknowledgeRequest

* AKCORE-26-3: Minor reformattings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants