Skip to content

KAFKA-12747: Fix flakiness in shouldReturnUUIDsWithStringPrefix #10643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guozhangwang merged 3 commits into from
May 10, 2021
Merged

KAFKA-12747: Fix flakiness in shouldReturnUUIDsWithStringPrefix #10643

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0acf3cc
fix flakiness
guozhangwang May 6, 2021
565d738
Merge branch 'trunk' of https://github.com/apache/kafka into K12747-f…
guozhangwang May 10, 2021
27132ba
github comments
guozhangwang May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
import static org.easymock.EasyMock.mock;
import static org.easymock.EasyMock.notNull;
import static org.easymock.EasyMock.reset;
import static org.hamcrest.CoreMatchers.either;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.notNullValue;
Expand Down Expand Up @@ -439,6 +440,8 @@ public void shouldReturnUUIDsWithStringPrefix() {
final UUID uuid1 = UUID.randomUUID();
final UUID uuid2 = UUID.randomUUID();
final String prefix = uuid1.toString().substring(0, 4);
final int numMatches = uuid2.toString().substring(0, 4).equals(prefix) ? 2 : 1;

entries.add(new KeyValue<>(
new Bytes(uuidSerializer.serialize(null, uuid1)),
stringSerializer.serialize(null, "a")));
Expand All @@ -460,8 +463,12 @@ public void shouldReturnUUIDsWithStringPrefix() {
numberOfKeysReturned++;
}

assertThat(numberOfKeysReturned, is(1));
assertThat(valuesWithPrefix.get(0), is("a"));
Copy link
Copy Markdown
Contributor

@jlprat jlprat May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still try to keep this assertion, something among the lines of:

if (clashOnPrefix) {
    assertThat(valuesWithPrefix.get(0), either(is("a")).or(is("b")));
} else {
    assertThat(valuesWithPrefix.get(0), is("a"));
}

Copy link
Copy Markdown
Contributor Author

@guozhangwang guozhangwang May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG, I will do that upon merging.

assertThat(numberOfKeysReturned, is(numMatches));
if (numMatches == 2) {
assertThat(valuesWithPrefix.get(0), either(is("a")).or(is("b")));
} else {
assertThat(valuesWithPrefix.get(0), is("a"));
}
}

@Test
Expand Down