POC for CheckStyle 8.42 regression (with 'Unnecessary Parentheses' errors)

[dejan2609]

⚠️ Not meant to be merged. Related to checkstyle/checkstyle#9957

@romani please note that I intentionally fine-grained this PR to a few commits (with appropriate messages, I hope you will find them useful). Rationale: my intention was to dissect important parts bit-by-bit (let me know in case you want me to change something).

Notable temporary changes:

• checkstyle gradle maxError property is introduced (just for counting error counting purposes)
• module Indentation is disable via checkstyle.xml (in this contex those errors are not relevant)

How to execute CheckStyle gradle tasks: ./gradlew checkstyleMain checkstyleTest
https://github.com/dejan2609/kafka/blob/apache-kafka-with-checkstyle-8.42/README.md#running-code-quality-checks

CheckStyle gradle configuration / config files:

• https://github.com/dejan2609/kafka/blob/apache-kafka-with-checkstyle-8.42/build.gradle#L588
• https://github.com/dejan2609/kafka/blob/apache-kafka-with-checkstyle-8.42/build.gradle#L712
• https://github.com/dejan2609/kafka/blob/apache-kafka-with-checkstyle-8.42/checkstyle/checkstyle.xml

build.gradle
gradle/dependencies.gradle
/chekstyle/ folder (with checkstyle config files)

ℹ️ Note: also related to this Kafka PR: #10656

[romani]

Unfortunately we need zero violations to be enforced. Only in this case we reliability can detect regression. Is it doable ? If team allow violations in mid of iteration, it is fine, at least we will use strict version of code where 0 violation.

[dejan2609]

Please note that Kafka project (trunk branch, that is) does not declare maxErrors property at all (i.e. that value defaults to zero).

As I mentioned via previous commit messages I just temporary declared maxErrors property/value pair for this PR in order to count how many errors we have to deal with.

Unfortunately we need zero violations to be enforced. Only in this case we reliability can detect regression. Is it doable ?

Done, commit is pushed (property removed).

[dejan2609]

Rebased onto trunk and force-pushed (as explained in a conversation/review above).

[dejan2609]

Note: comment (related to a different PR) was accidentally submitted here and then deleted... sorry for spamming.

[dejan2609]

(Will be) solved elsewhere and hence closing in favor of #10698

[romani]

@dejan2609 , fix for checkstyle/checkstyle#9957 will be released in 2 weeks.

[dejan2609]

Thanx for info @romani, much appreciated !