KAFKA-12747: Fix flaky test RocksDBStoreTest.shouldReturnUUIDsWithStr…#10662
Closed
jlprat wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-12747: Fix flaky test RocksDBStoreTest.shouldReturnUUIDsWithStr…#10662jlprat wants to merge 1 commit intoapache:trunkfrom
jlprat wants to merge 1 commit intoapache:trunkfrom
Conversation
…ingPrefix Fixes the test by checking if there is a prefix collision. In a collision case, assert statements are adapted to check for both values. Alternatively, we could re-generate the second UUID in case of prefix clash until they are clash-free.
Contributor
Author
|
Now I see another PR was already there: #10643 |
Contributor
|
Hey @jlprat sorry I was not aware you're also working on this ticket.. |
Contributor
Author
|
The other way around, I haven't seen your PR, you were first 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ingPrefix
Fixes the test by checking if there is a prefix collision.
Following comment on JIRA ticket, in case of prefix clash, we check that the returned value can be either of both (a or b).
Alternatively, we could re-generate the second UUID in case of prefix
clash until they are clash-free.
Committer Checklist (excluded from commit message)