MINOR: Apply try-with-resource to KafkaStreamsTest#10668
Merged
mjsax merged 1 commit intoapache:trunkfrom Jun 3, 2021
Merged
Conversation
46babe0 to
d91a8e4
Compare
Contributor
Author
|
@mjsax , @ableegoldman |
chia7712
reviewed
May 11, 2021
mjsax
reviewed
May 11, 2021
mjsax
reviewed
May 11, 2021
Member
|
@vitojeng -- Seems there is some conflicts. Can you rebase your PR so we can merge it? |
d91a8e4 to
c53e84a
Compare
Contributor
Author
|
Thanks @mjsax ! |
Member
|
Thanks @vitojeng! Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the PR #9821, @mjsax 's comment
Let me address this before the KAFKA-5876(KIP-216) part 5.
Committer Checklist (excluded from commit message)