Skip to content

KAFKA-2384; Encode/decode to utf-8 for commit title IO in kafka-merge-pr.py#109

Closed
ijuma wants to merge 1 commit intoapache:trunkfrom
ijuma:kafka-2384-hotfix
Closed

KAFKA-2384; Encode/decode to utf-8 for commit title IO in kafka-merge-pr.py#109
ijuma wants to merge 1 commit intoapache:trunkfrom
ijuma:kafka-2384-hotfix

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Aug 4, 2015

This fix should be fine for Linux and OS X. Not sure about Windows though. This is a very specific fix for new functionality added in KAFKA-2384. There are other places where a similar error could occur, but are less likely.

The script doesn't really support Unicode input at the moment.

@asfbot
Copy link
Copy Markdown

asfbot commented Aug 4, 2015

kafka-trunk-git-pr #82 FAILURE
Looks like there's a problem with this pull request

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Aug 4, 2015

The failure is unrelated to this PR as it only changes the merge script.

@asfgit asfgit closed this in 1a0179f Aug 4, 2015
@guozhangwang
Copy link
Copy Markdown
Contributor

PR #98 works, LGTM.

@ijuma ijuma deleted the kafka-2384-hotfix branch August 14, 2015 09:48
efeg pushed a commit to efeg/kafka that referenced this pull request Jan 29, 2020
* Fix the comparison of user requests
ambroff pushed a commit to ambroff/kafka that referenced this pull request Jan 20, 2021
davide-armand pushed a commit to aiven/kafka that referenced this pull request Dec 1, 2025
fvaleri added a commit to fvaleri/kafka that referenced this pull request Mar 27, 2026
Add source cluster ID in list mirror
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants