KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest#10904
Closed
tang7526 wants to merge 2 commits intoapache:trunkfrom
Closed
KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest#10904tang7526 wants to merge 2 commits intoapache:trunkfrom
tang7526 wants to merge 2 commits intoapache:trunkfrom
Conversation
Contributor
Author
|
@chia7712 Could you help to review this PR? thanks. |
ijuma
requested review from
chia7712,
ijuma,
kkonstantine and
rhauch
and removed request for
ijuma
Member
|
Thanks for the PR. We should update build.gradle to remove this test from the JDK 16 exclusion list. |
tang7526
force-pushed
the
minor/WorkerGroupMemberTest
branch
from
a84d84d to
c83168e
Compare
Contributor
Author
Done. I have already removed this test from the JDK 16 exclusion list. |
tang7526
force-pushed
the
minor/WorkerGroupMemberTest
branch
3 times, most recently
from
1bdeaaf to
20519ee
Compare
tang7526
changed the title
tang7526
force-pushed
the
minor/WorkerGroupMemberTest
branch
from
20519ee to
41091b6
Compare
ijuma
reviewed
Sep 6, 2021
Member
ijuma
left a comment
ijuma
left a comment
There was a problem hiding this comment.
Thanks for the PR. A couple of comments/questions below.
| @RunWith(PowerMockRunner.class) | ||
| @PrepareForTest({ConnectUtils.class}) | ||
| @PowerMockIgnore({"javax.management.*", "javax.crypto.*"}) | ||
| @ExtendWith(MockitoExtension.class) |
Member
There was a problem hiding this comment.
Have we verified that this JUnit 5 feature works correctly even though we're using the junit vintage engine in this module still?
Member
|
@tang7526 are you planning to work on this? If not, I would like to take it over. |
Member
|
Closing this in favor of #12484. |
ijuma
pushed a commit
that referenced
this pull request
Aug 10, 2022
…upMemberTest.java (#12484) This PR is created on top of #10904 and includes commits from original author for attribution. ## Testing 1. `./gradlew connect:runtime:unitTest --tests WorkerGroupMemberTest` is successful. 2. Verified that test is run as part of `./gradlew connect:runtime:unitTest` (see report in the PR) Reviewers: Ismael Juma <ismael@juma.me.uk> Co-authored-by: Chun-Hao Tang <tang7526@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest
https://issues.apache.org/jira/browse/KAFKA-13060
Committer Checklist (excluded from commit message)